eventespresso / ee4-events-calendar

Event Espresso Calendar addon (for EE4+)
0 stars 3 forks source link

Allow 'all-day' text to be translatable and set the time format uses on the calendar axis #18

Open Pebblo opened 3 years ago

Pebblo commented 3 years ago

See: https://eventespresso.com/topic/calendar-time-column/?view=all#post-326944

The changes in this branch allow for the default 'all-day' text used by full calendar to be translated.

It also adds a 'axis time format' option to the calendar settings to allow users to change the format used there. (the default value for that option/parameter it what fullCalendar already uses)

How has this been tested

Go to Event Espresso -> Calendar

In basic settings you should have a 'Axis Settings' option and the default value should be h(:mm)tt

Open up the calendar in a new tab and check the Week and day views, confirm they show times on the left using the format 6pm.

In the settings again, change the format, for example, remove the tt and save, then confirm that value saves when you save the config.

Back to the front end calendar again, hard refresh and confirm the week and day views show the correct format (in this example, no AM/PM)

For the all-day text, install Pig Latin, activate it and confirm that with that plugin active the calendar displays something like allay-ayday, if so that string is now translatable.

Checklist

Pebblo commented 3 years ago

Thanks, Brent! Feeling a little rusty now as I should have picked up on those lol

Dismissed review as GitHub showed requested changes even though they were done.

sethshoultes commented 3 years ago

Testing Notes:

Additional Testing Notes:

sethshoultes commented 3 years ago

@Pebblo did you see my notes above?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ghost commented 2 years ago

Tested it and works as expected! 💯