Open Pebblo opened 3 years ago
Thanks, Brent! Feeling a little rusty now as I should have picked up on those lol
Dismissed review as GitHub showed requested changes even though they were done.
Testing Notes:
Additional Testing Notes:
\c\u\s\t\o\m
in the text field when selected and the settings are saved, no matter what is entered into the field: https://www.screencast.com/t/kTinyc73f@Pebblo did you see my notes above?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Tested it and works as expected! 💯
See: https://eventespresso.com/topic/calendar-time-column/?view=all#post-326944
The changes in this branch allow for the default 'all-day' text used by full calendar to be translated.
It also adds a 'axis time format' option to the calendar settings to allow users to change the format used there. (the default value for that option/parameter it what fullCalendar already uses)
How has this been tested
Go to Event Espresso -> Calendar
In basic settings you should have a 'Axis Settings' option and the default value should be
h(:mm)tt
Open up the calendar in a new tab and check the Week and day views, confirm they show times on the left using the format
6pm
.In the settings again, change the format, for example, remove the
tt
and save, then confirm that value saves when you save the config.Back to the front end calendar again, hard refresh and confirm the week and day views show the correct format (in this example, no AM/PM)
For the all-day text, install Pig Latin, activate it and confirm that with that plugin active the calendar displays something like
allay-ayday
, if so that string is now translatable.Checklist
esc_html__()
, see https://codex.wordpress.org/I18n_for_WordPress_Developers)