search

eventespresso / ee4-events-calendar

Event Espresso Calendar addon (for EE4+)
0 stars 3 forks source link

Check we have an eeCAL object before using it fixes #5 #6

Closed Pebblo closed 6 years ago

Pebblo commented 6 years ago

Fixes #5

tn3rb commented 6 years ago

sry for the delay... my Boards view had other repos off by accident

Pebblo commented 6 years ago

Thanks Brent.

@joshfeck do you want to take a quick run at this? I've tested it and didn't run into any problems.

To test I just used this branch and confirmed that the calendar continued to load as normal on my site.

Then added: https://gist.github.com/joshfeck/5d9c88fea504c0b111c3df8f24ad25d9

Removed the check for the calendar page so it loaded everywhere.

Checked that the site continued to load the calendar on the normal page with no JS errors and that no JS errors were thrown on pages that did not contain the ESPRESSO_CALEDNAR shortcode.

I actually gave this fix to another user a little while ago and they've been using it without any problems so this is mainly just confirming there's nothing obvious wrong with this before release.

joshfeck commented 6 years ago

Tested and verified the fix. Ready for merging.