search

eventespresso / eea-attendee-mover

Addon for EE4+
GNU General Public License v2.0
0 stars 2 forks source link

Error while using Attendee mover with decaf #19

Closed Saam01 closed 2 years ago

Saam01 commented 2 years ago

When I am using Attendee mover with decaf, it is showing the below error:

image Error

garthkoyle commented 2 years ago

Yes, I can confirm the same fatal. Is this intentional @Pebblo or @tn3rb ? image

garthkoyle commented 2 years ago

I don't have this issue with EE Master, EE Dev nor Attendee Mover Master.

hoseinrafiei commented 2 years ago

I don't have this issue with EE Master, EE Dev nor Attendee Mover Master.

I have this issue in EE master and decaf mode. But everything works fine in EE master when using caff version.

garthkoyle commented 2 years ago

I have this issue in EE master and decaf mode. But everything works fine in EE master when using caff version.

Yes, the remaining issue is with Decaf + Attendee Mover.

garthkoyle commented 2 years ago

@Pebblo and @tn3rb is the attendee mover supposed to work with Decaf or not? If not, should it completely fatal like that?

tn3rb commented 2 years ago

i don't think it should work with decaf but it should also not fatal like that. so definitely a bug in the attendee mover

garthkoyle commented 2 years ago

Ya, agreed.

yes, that’s what I’m hoping. But I don’t know if that is the case with the Attendee Mover specifically. Some add-ons do work with Decaf, and I want to be sure Attendee Mover does not. But I’m uncertain because it just throws a Fatal Error rather than something more intelligent saying that a different version of EE is required.

Pebblo commented 2 years ago

So afaik, with regards to Decaf we have always considered add-ons to not work with it, some may do, but for as long as I can remember we've always advised that to use the add-ons you need to use the full version of EE4.

Now, having said that, the above I would still consider a bug as it's adding the icon then just throwing a fatal when you use it, the add-on should just not add its functionality at all if that is possible here.

garthkoyle commented 2 years ago

Thanks. It's a bug with Decaf and/or Attendee Mover then.

tn3rb commented 2 years ago

Fix merged to master plz test to confirm

hoseinrafiei commented 2 years ago

I checked and it works fine. After activating the plugin on decaf it throws an error and deactivates again. Also if you activate on caff version and switch to decaf later, same thing happens for attendee mover and gets deactivate immediately.

Screen Shot 2022-05-25 at 16 33 35
Saam01 commented 2 years ago

Working Perfectly. This ticket can be closed now.