search

eventespresso / eea-attendee-mover

Addon for EE4+
GNU General Public License v2.0
0 stars 2 forks source link

Order events by DTT_EVT_end so older events are shown after 'later' e… #9

Closed Pebblo closed 5 years ago

Pebblo commented 5 years ago

Reported here: https://eventespresso.com/topic/transfer-to-new-event-and-ticket-type-tweak/

I agree that the list needs to be ordered better, personally, I prefer EVT_ID but Datetime.DTT_EVT_end may be a better choice?

Events are currently ordered by DTT_ID => ASC which makes the list rather odd for people navigate easily.

As an example, if you have 12 events called 'Test Event' over the next 12 months (1 per month) and want to move the user to the event in the series you search for it but the correct event is the last entry in the list because you'll see older datetimes first.

If we order events by Datetime.DTT_EVT_end => DESC the list is little easier to follow.

I'd say moving registrations from older events to newer is going to be more common than the opposite.

tn3rb commented 5 years ago

why DTT_EVT_end ??? why not DTT_EVT_start ???

Consider the following: (plz note: I've edited this after its initial posting because I missed that you also wanted to sort DESC and not ASC)

So I'm all for ordering chronologically (and likely should have done that by default), but think it would be better to do so using the start date and sort ASC. I'm open for counter arguments of course.

Pebblo commented 5 years ago

I'm fine with DTT_EVT_start (I used _end simply because that's what the query is based on), but I don't think it should be ASC as you still have the same problem of old events first.

IMO you're more likely to receive something like:

Yo Brent! So I'm booked on an event on 4th Fed - Monday All-Day Session right, but the thing is, I've just received an email from the distant uncle that I didn't even know I had! Apparently, he's like a prince of this place that no-one has ever heard of, with a currency that I don't even know.... but he's giving me 40bazillion of it... I've just got to fly out there on Monday to sign some paperwork and they want to photocopy my bank card (strange huh?) so I can't make it, can you move me to Friday, please?

Than you are to receive:

Yo Brent! So I'm booked on an event on 8th Fed - Firday All-Day Session right, but the thing is, I've just got back early from visiting this uncle that I didn't know I had, who gave my 40bazillion lamalama coin because apparently he's this prince and just wanted to splash out a little.... he just needed my bank card for a couple of mins beforehand (I know, right... he must lose a lot of bank cards if he needed mine!). So can you move me from Friday to Monday, please?

Not that either wouldn't happen, but as an admin, you're more likely to receive an "I can't make it on X can you move me to the later event on Y" than you are to receive the opposite because, well stuff can just come up at the last minute more often, right? So when we display the 'earlier' events first we force the majority of requests to filter through those first.

With regards to the examples above, with the way that is above they look like they would be datetimes? Or possible groups of datetimes within events:

Conference Event - Main Conference Event - Monday (Morning, Afternoon, All-day datetimes) Conference Event - Tuesday (Morning, Afternoon, All-day datetimes) and so on

So you wouldn't see those individual dates in that way as you'd just see the event itself, unless I'm misunderstanding the example?

But even if not, and they did display as the second example, at least the 'later' events are listed before the others, so when you're asked to move an attendee to Friday you don't wade through Mon-Thur every time.

tn3rb commented 5 years ago

ok let's use DTT_EVT_start and as long as @joshfeck is ok with sorting using DESC then we'll go with that. I still personally think that regular chronological order is the most logical/common/expected sort method but am fine to let Josh be the tie breaker.

joshfeck commented 5 years ago

We may have some conflicting work happening in https://github.com/eventespresso/event-espresso-core/pull/1030

joshfeck commented 5 years ago

The part that's odd to me, that hasn't been addressed, is when an event has multiple datetimes. When there are multiple datetimes, the datetime displayed in the option is always the very first datetime of the event. What's displayed can actually make the changes in this branch look like there's a bug.

For example, this screenshot Screen Shot 2019-03-22 at 9 05 34 AM is from a test site that has this PR's branch on it.

You'll note it's sorted DESC, ordered by next upcoming Datetime start date. It's definitely an improvement that it's sorting by start date instead of datetime ID. The confusing part, where this can be improved, is display. The datetime for each event that's displayed is the first occurring datetime. So it can look out of order.

Compared with master branch where the order is by datetime ID, where the datetime has not expired:

Screen Shot 2019-03-22 at 9 09 51 AM

The order looks correct, but why are there events from Oct & Dec from last year? The reason is because there are non-expired datetimes in that event.

In summary, I do think it's an improvement to order by DTT_start_date, but I think the datetime date that's displayed needs to match the datetime that's used to order by. I'm less concerned about the sort order (DESC vs. ASC) but I lean toward ASC.

joshfeck commented 5 years ago

This is much improved.

Current release: Screen Shot 2019-04-15 at 1 58 15 PM

This branch: Screen Shot 2019-04-15 at 1 58 56 PM