eventflow / EventFlow

Async/await first CQRS+ES and DDD framework for .NET
https://geteventflow.net
Other
2.39k stars 445 forks source link

Migrate hangfire to support new version #1000

Closed kyle-bradley closed 1 year ago

kyle-bradley commented 1 year ago

PR Comments

I removed the include for the service in the project file as I couldn't find what it pointed to. Please let me know if this is needed. <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />

I also found that often a task is returned without being resolved in method e.g. return _jobRunner.ExecuteAsync(jobName, version, job, CancellationToken.None);

I generally await the tasks in method to avoid exceptions bubbling up and potential side-effects. Is not awaiting tasks is the preferred approach? I don't want to diverge from the standards set for the project unnecessarily.

Future Work

github-actions[bot] commented 1 year ago

Hello there!

We hope this message finds you well. We wanted to let you know that we have noticed that there has been no activity on this pull request for the past 90 days, which makes it a stale pull request.

As a result, we will be closing this pull request within the next seven days. If you still think this pull request is necessary or relevant, please feel free to update it or leave a comment within the next seven days.

Thank you for your contributions and understanding.

Best regards, EventFlow

github-actions[bot] commented 1 year ago

Hello there! I'm a bot and I wanted to let you know that your pull request has been closed due to inactivity after being marked as stale for seven days. If you believe this was done in error, or if you still plan to work on this pull request, please don't hesitate to reopen it and let us know. We're always happy to review and merge high-quality contributions. Thank you for your interest in our project! Best regards, EventFlow