search

eventflow / EventFlow

Async/await first CQRS+ES and DDD framework for .NET
https://geteventflow.net
Other
2.39k stars 445 forks source link

Update from System.Data.SqlClient to Microsoft.Data.SqlClient in v1.x #1024

Closed janrybka closed 7 months ago

janrybka commented 7 months ago

Details in of update in discussion: https://github.com/eventflow/EventFlow/discussions/1022#discussion-6435423

This is first PR. The second will be to develop-v0. Unfortunately I don't have any sample project to run tests on. Changes looks straight forward, build and unit tests passes, so there shouldn't be problems with runtime library mismatches.

I'm currently running test on v0 version. I'll post those once finished.

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

janrybka commented 7 months ago

I see I need to disable cert validation on SQL connection in tests... Work ongoing...

... Done

rasmus commented 7 months ago

@janrybka there seems to be something odd with the CLA. Are your commits done using an email verified on GitHub?

janrybka commented 7 months ago

@janrybka there seems to be something odd with the CLA. Are your commits done using an email verified on GitHub?

Yes, I used the wrong one on this repo. Fixed.

rasmus commented 7 months ago

❤️