search

eventflow / EventFlow

Async/await first CQRS+ES and DDD framework for .NET
https://geteventflow.net
Other
2.39k stars 445 forks source link

v0: Update from System.Data.SqlClient to Microsoft.Data.SqlClient in v0.x #1027

Open janrybka opened 7 months ago

janrybka commented 7 months ago

Details in of update in discussion: https://github.com/eventflow/EventFlow/discussions/1022#discussion-6435423

PR contains minimal set of changes to make transfer to Microsoft.Data.SqlClient successful. Threat warning as errors caused problems for valnerable packages. I've updated only Newtonsoft.Json as this I could test. I didn't have any MongoDB or Owin project to test on, so these are now marked with "NoWarn" option. I could try to update those also, but in this case I'd go with Yurii's PR and update all.

rasmus commented 7 months ago

Nice and clean PR.

0.x builds aren't working (need help or time to get them up and running again), but I'll try to verify this manually to see if it can be merged.

janrybka commented 7 months ago

I've tried to get build.ps1 up, but I only got it to run by commenting out #module nuget:?package=Cake.DotNetTool.Module. Unfortunately, it hang on unit tests. I also didn't know how to knit it with GitHub workflow, so I gave up at the point.

rasmus commented 1 month ago

I'm working on getting a GHA runner up and running for EventFlow that has Docker properly configured (Linux containers).

rasmus commented 1 month ago

@janrybka I have gotten builds up and running for v0 again. It left some merge conflicts with this PR though