search

eventflow / EventFlow

Async/await first CQRS+ES and DDD framework for .NET
https://docs.geteventflow.net/
Other
2.33k stars 442 forks source link

Migrate RabbitMq to V1 #995

Closed kyle-bradley closed 1 year ago

kyle-bradley commented 1 year ago

I will also be upgrading the RabbitMq implementation to dispatch both events and commands. Allowing both to be sent over a message queue. I sometimes employed this strategy for sending commands from a Sagas back to the respective services.

rasmus commented 1 year ago

The TreatWarningsAsErrors is removed, something that is required. Removing it lets all sorts of small errors make their way into the code base.

kyle-bradley commented 1 year ago

The TreatWarningsAsErrors is removed, something that is required. Removing it lets all sorts of small errors make their way into the code base.

It was moved in the main RabbitMq project to align with the format of the other projects. Only removed it from the Tests project as I based the build settings on the other extension test projects.

However, I see that you have updated these settings across the board. Will merge and make sure that these changes are reflected correctly.