eventhorizon5 / skyscraper

The Skyscraper Project (Skyscrapersim) - an open source building, city, and elevator simulator
https://www.skyscrapersim.net
GNU General Public License v2.0
28 stars 7 forks source link

NotifyEarly = -1 not in effect when elevator is called on the same floor. #15

Closed MultiMonorail closed 1 year ago

MultiMonorail commented 1 year ago

Regarding the new NotifyEarly parameter: When someone calls the elevator and both them and the elevator are on the same floor, the elevator will still chime even if NotifyEarly is set to -1.

eventhorizon5 commented 1 year ago

That's something I'll look into, it happens because the NotifyEarly only affects arrival notifications (NotifyArrival() function), and if the elevator is on the same floor, that's not a standard arrival and so another handler (I think in the elevator door code) performs the chime.

eventhorizon5 commented 1 year ago

This has been fixed. Callbuttons now use the NotifyArrival() function along with a check for the NotifyEarly parameter.