eventhorizon5 / skyscraper

The Skyscraper Project (Skyscrapersim) - an open source building, city, and elevator simulator
https://www.skyscrapersim.net
GNU General Public License v2.0
28 stars 7 forks source link

Destination Dispatch Bugs & Suggestions #22

Open MultiMonorail opened 1 year ago

MultiMonorail commented 1 year ago

Here are some bugs I found while playing with the Destination Dispatch system in it's initial form:

This also has an effect on a multiple elevator scenario:

Also, the directional chime and lights don't work, I'm not sure if this was intended.

One more thing: Floor buttons inside the elevator should still light up even in DD and hybrid mode. This is seen in many elevators with a hybrid configuration.

Besides all of that, this is a good start to the Destination Dispatch feature!

MultiMonorail commented 1 year ago

Tested the new update, and looks like most of the stuff is good! There is a couple things though:

eventhorizon5 commented 1 year ago

The minus and star buttons are now fixed, I had just forgotten to add the new code for them and do testing. I'll fix the Triton Center too.

MultiMonorail commented 1 year ago

I just found some new things:

eventhorizon5 commented 1 year ago

Both those issues have been fixed. The second one had to do with how the controller wouldn't allow multiple identical destinations, I removed that check and it works now.

MultiMonorail commented 1 year ago

Just tested out the new update, and it looks like all of the issues are now fixed! I do have something that I would like to suggest that hasn't already been talked about:

In many DD systems, the indicator is placed within the digital touchscreen panel:

https://user-images.githubusercontent.com/109993536/234938231-bfc211e9-acaa-4836-a14c-95bb49dca563.mp4

Would it be possible to recreate this in Skyscraper? In the current state, if I try to recreate it by putting the indicator over the button panel, the indicator blocks the buttons, even with a clear texture.

What I think would be best is to have an option for the indicator being able to be clicked through. That way, the keypad function can still work, as shown in the video.

eventhorizon5 commented 1 year ago

A clear texture won't fix the problem you're having, because the simulator does a raycast to hit the indicator (polygon), and so even if a clear texture is used, the polygon is still there and it gets hit. I can look into if the indicator can be tagged invisible so that the raycast won't hit it, I haven't tried doing that before so I'm not exactly sure how it would be done yet.

aeroglass7 commented 4 months ago

I found another glitch: If you enter a destination on one call station, it works exactly how it's supposed to. However, if you already did that and then enter that same floor on another call station, then the one you originally entered your floor on will chime and show the assigned car letter. In real life, whichever one you use will show you the car letter, regardless of whichever one was previously used for the same floor.