eventhorizon5 / skyscraper

The Skyscraper Project (Skyscrapersim) - an open source building, city, and elevator simulator
https://www.skyscrapersim.net
GNU General Public License v2.0
28 stars 7 forks source link

Idle Sound Issue #24

Closed MultiMonorail closed 1 year ago

MultiMonorail commented 1 year ago

Custom elevator idle sounds are not functioning properly. The default sound is always playing, even if a custom sound is assigned in the building code.

eventhorizon5 commented 1 year ago

Interesting, is this happening in both the Alpha 11 release and the current build, or just the current build?

MultiMonorail commented 1 year ago

It appears to be happening in just the current build.

eventhorizon5 commented 1 year ago

CarIdleSound and MotorIdleSound parameters are working fine, is this for the old IdleSound parameter? That one I think has issues, but it should also be broken in Alpha 11 if I'm seeing the code right.

eventhorizon5 commented 1 year ago

Found it, it was the addition of the ID parameter, it didn't do the line check properly, I'll check things over to make sure there's no more script breakage.

eventhorizon5 commented 1 year ago

This has been fixed in Git.

eventhorizon5 commented 1 year ago

Since you said this is still not working, I'm testing it now and using the IdleSound command, and it works fine. I'll check some other commands, but what building and idle sound command are you using that's breaking?

MultiMonorail commented 1 year ago

I meant the destination indicator sound, not the idle sound. The idle sound is working as it should.

eventhorizon5 commented 1 year ago

Thanks for that, I'll see what's going on.