search

eventhorizon5 / skyscraper

The Skyscraper Project (Skyscrapersim) - an open source building, city, and elevator simulator
https://www.skyscrapersim.net
GNU General Public License v2.0
28 stars 7 forks source link

macOS Bugfixes #8

Closed ghost closed 1 year ago

ghost commented 1 year ago

Can't speak for anyone else besides M1 users, but the title screen used to have the menu image in the upper left, while the buttons were in the center of the window, so this PR fixes it.

As for ingame, mouse input seems to correspond to the upper left, (hard to explain, but you'd need to center what you're looking at relative to the upper left's quarter of the screen) which is why camera.cpp is multiplied to. (See image)

Screenshot 2022-10-03 at 12 13 29 AM

Also added a script that recreates however https://www.skyscrapersim.net/downloads/dev/skyscraper-100122-macos.dmg was created. make install does the trick.

eventhorizon5 commented 1 year ago

Thanks for this, I'm reviewing the changes, and noticed in the wxWidgets documentation that it says that Macs with Retina displays have a ContentScaleFactor of 2.0, I didn't notice any issues since I have a Mac Mini with a regular monitor connected to it (scaling factor of 1), so that's why you were having issues. Thanks for testing, I've needed more people to do tests especially on Mac.

eventhorizon5 commented 1 year ago

I've merged your changes including my code modifications to it, thanks for your help.