search

eventuate-foundation / eventuate-cdc

Other
73 stars 31 forks source link

BinlogEntryReader - failed to call stopCountDownLatch.countDown() #121

Open kwonglau opened 2 years ago

kwonglau commented 2 years ago

https://github.com/eventuate-foundation/eventuate-cdc/blob/master/eventuate-local-java-cdc-connector-common/src/main/java/io/eventuate/local/common/BinlogEntryReader.java#L135

e.getMessage() could be null and it is causing NPE. As a result, the following are not called.

stopCountDownLatch.countDown();
throw new RuntimeException(e);
cer commented 2 years ago

@dartartem processingError should probably be Optional<Throwable>

dartartem commented 2 years ago

@dartartem processingError should probably be Optional<Throwable>

@cer thank you, I will investigate