search

eventuate-foundation / eventuate-messaging-kafka

Other
13 stars 11 forks source link

Why do services need to @Import KafkaConsumerFactoryConfiguration #42

Open cer opened 4 years ago

cer commented 4 years ago

For example, see https://github.com/microservices-patterns/ftgo-application/pull/108

dartartem commented 4 years ago

It seems it is not necessary anymore.

KafkaConsumerFactory is added to OrderHistoryServiceMessagingConfiguration by this commit: https://github.com/microservices-patterns/ftgo-application/pull/108/commits/6669693e3277ee7bf218590fe790c0b5899c4cfe because tram was not updated to latest kafka.

Now tram contains KafkaConsumerFactory in EventuateTramKafkaMessageConsumerConfiguration : https://github.com/dartartem/eventuate-tram-core/blob/master/eventuate-tram-spring-consumer-kafka/src/main/java/io/eventuate/tram/spring/consumer/kafka/EventuateTramKafkaMessageConsumerConfiguration.java#L15

And order history service uses EventuateTramKafkaMessageConsumerConfiguration here: https://github.com/microservices-patterns/ftgo-application/blob/master/ftgo-order-history-service/src/main/java/net/chrisrichardson/ftgo/cqrs/orderhistory/main/OrderHistoryServiceMain.java#L17

So no need to define KafkaConsumerFactory in OrderHistoryServiceMessagingConfiguration: https://github.com/microservices-patterns/ftgo-application/blob/master/ftgo-order-history-service/src/main/java/net/chrisrichardson/ftgo/cqrs/orderhistory/main/OrderHistoryServiceMain.java#L14

I will remove it.