eventuate-tram / eventuate-tram-core

Transactional messaging for microservices
Other
1.05k stars 186 forks source link

ReactiveTramEventTransactionIntegrationTest appears to use the database and kafka #155

Open cer opened 3 years ago

cer commented 3 years ago

I don't the behavior that is being tested by the class needs to use the Database or Kafka.

I believe what it's testing is that the event handler is executed within a transaction that's rolled back if it throws an exception. Also, isn't this behavior nothing to do with DomainEvent* and in fact do with the MessageHandling?

https://github.com/eventuate-tram/eventuate-tram-core/blob/6a0ad01bfd2886454ff188a73f19252893f80fc0/eventuate-tram-spring-reactive-integration-tests/src/test/java/io/eventuate/tram/reactive/integrationtests/ReactiveTramEventTransactionIntegrationTest.java#L19