eventure / hide.client.linux

Hide.me CLI VPN client for Linux
https://hide.me
GNU General Public License v2.0
90 stars 35 forks source link

scripts uses bash idioms in ash script #37

Open solsticedhiver opened 3 months ago

solsticedhiver commented 3 months ago

the scripts in scripts directory use a lot of bash idioms that will only run in bash and not ash or dash.

Please use bash in shellbang instead.

Some example:

Possible bug:

line 22 of hideme-accesToken.ash: if [[ $? == "22" ]];

You compare the output result which is an integer to a string. that will always be false. Use something like if [ $? -eq 22 ] of better if [ $? -ne 0 ]