Optional hubot.env for VCS users

evenup / evenup-hubot

Puppet module for managing hubot

Other

8 stars 36 forks source link

Optional hubot.env for VCS users #25

Closed bilco105 closed 9 years ago

bilco105 commented 9 years ago

This adds support for optionally specifying hubot::env_export when configuring hubot from a VCS repo.

We use this because our hubot installation requires a number of sensitive env variables (API credentials, etc) - that we don't want to check into a git repository unencrypted.

Using this change, we're able to store these values in hiera, which we can encrypt using hiera-eyaml.

jlambert121 commented 9 years ago

Thanks! Could you add some tests around it?

bilco105 commented 9 years ago

Done. Sorry for the delay!

jlambert121 commented 9 years ago

Sorry, one more. Could you test the negative as well? If env_export isn't set it should_not contain the env file. After that it's good to merge!

bilco105 commented 9 years ago

@jlambert121 - https://github.com/bilco105/evenup-hubot/blob/hubot_env_vcs/spec/classes/hubot_spec.rb#L68 :)

jlambert121 commented 9 years ago

Thanks!