evepraisal / go-evepraisal

the code that powers evepraisal.com
https://evepraisal.com
MIT License
145 stars 103 forks source link

Incorrect results for some items at Rens #44

Open nagledb opened 6 years ago

nagledb commented 6 years ago

I think I'm getting incorrect results on some items at Rens.

Here's the evepraisal I was looking at: http://evepraisal.com/a/dg0yn

And here are market exports from Rens for those items: Heimatar-Amarr TIL-1 Nexus Chip-2017.11.14 191226.txt Heimatar-AML Compact Omnidirectional Tracking Link-2017.11.14 191834.txt Heimatar-Blue Pill-2017.11.14 191839.txt Heimatar-Data Sheets-2017.11.14 191844.txt Heimatar-Faint Epsilon Scoped Warp Scrambler-2017.11.14 191848.txt Heimatar-Freed Slaves-2017.11.14 191853.txt Heimatar-Freedom Fighters-2017.11.14 191858.txt Heimatar-High-Tech Small Arms-2017.11.14 191903.txt Heimatar-Limited Light Neutron Blaster I-2017.11.14 191907.txt Heimatar-Medium Asymmetric Enduring Remote Shield Booster-2017.11.14 191912.txt Heimatar-Modal Light Ion Particle Accelerator I-2017.11.14 191917.txt Heimatar-Suppressed Targeting System I-2017.11.14 191921.txt Heimatar-Ta3 Compact Ship Scanner-2017.11.14 191926.txt Heimatar-Type-D Restrained Overdrive Injector-2017.11.14 191930.txt Heimatar-Ukomi Superconductors-2017.11.14 191934.txt Heimatar-Upgraded Explosive Deflection Amplifier I-2017.11.14 191939.txt

Some examples:

Amarr TIL-1 Nexus Chip is selling for 8m and buying for 10k, but the evepraisal says it's 1.1m sell and 1.3m buy.

AML Compact Omnidirectional Tracking Link is selling for 5k at the Rens hub, but 3.5k at Balginia (3 jumps away). The evepraisal is showing the 3.5k value. I thought the evepraisal was supposed to target the specific hub station, but maybe I misunderstood? The only buyer is at 1.5k at 5 jumps away, but evepraisal says it's buying at 400k.

Not all of them are wrong though. For example, the Blue Pill evepraisal matches the market.

sudorandom commented 6 years ago

It should be looking specifically at the Rens system to see if there are any market orders. If there are too few items to get a good judge of the price of an item, it will expand its search to the "Universe" selection in leu of giving back nothing. You can tell when this happens by looking at the item detail page under the Rens tab and you will see "Market Pricing (low market volume)":

Perhaps one improvement is to expand to orders within the region (in ren's case, Heimatar) and seeing if there are enough orders to get a representative price from there first.