ever-been / everBeen

EverBEEN is a generic benchmarking environment focused on platform-independent middleware benchmarking.
www.everbeen.cz
GNU Lesser General Public License v3.0
7 stars 3 forks source link

Basic SWRepository functionality #68

Closed radek-macha closed 11 years ago

radek-macha commented 11 years ago
radek-macha commented 11 years ago

Started work in b7eb72fb19bcac10d0e710be3c818eaf5729ec64

radek-macha commented 11 years ago

@donarus, @sixtam I keep coming across this all the time. I think it'd be better for the Bpk entity to become an interface with an InputStream Bpk#getInputStream() method, as opposed to File Bpk#getFile(). Would that be a problem?

sixtam commented 11 years ago

@radek-macha Not for me.

radek-macha commented 11 years ago

Some related refactoring in e1fae1b8e8c29098b4d77f705b0a84fd75e41b61.

sixtam commented 11 years ago

What is the expected behavior of concurrent uploads of the same BPK? The code suggests that concurrent uploaders will overwrite each others files.

radek-macha commented 11 years ago

See this issue's description for expected behavior. As of now, the overwrite will happen. I am planning to revisit concurrency once the full features regarding Maven artifacts are implemented.

radek-macha commented 11 years ago

Artifact get/put (forgot to hash this): b6001b69ec00a71605d3dd0b5bd53f30c72671da

radek-macha commented 11 years ago

Collective decision lead to closing this issue without the duplicit entry denial for the moment, to allow easier debugging of other features. Covered by #74.

The SWRepository implements above features in a blocking way (i.e. one listener thread which blocks whenever it is processing a request). This is unsuitable for handling production payload. Covered by #75.