search

ever-co / ever-demand

Ever® Demand™ - Open Commerce Platform - https://everdemand.co
https://everdemand.co
GNU Affero General Public License v3.0
1.72k stars 461 forks source link

feat: add maximum delivery radius settings #1274

Closed valiopld closed 4 years ago

valiopld commented 4 years ago

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

https://www.loom.com/share/59f8adf876524495b2b65a3ca827d546 For now, just added a field in the DB with a delivery radius which can be controlled from warehouse's settings page !! It is not replaced yet with the hardcoded 50000m

**not sure is that the best place in warehouse's settings to add this controller @evereq

valiopld commented 4 years ago

Also now in the DB the "maxDistance" is storing inside the deliveryAreas collection image Not sure if it's okay or should be outside and separately

evereq commented 4 years ago

Also now in the DB the "maxDistance" is storing inside the deliveryAreas collection image Not sure if it's okay or should be outside and separately

think it should be fine for now, just make sure that value of maxDistance is in meters, not km :D Also that structure of deliveryAreas field I think it actually GeoJSON, so make sure that value you added does not make any troubles in the code to read it later (e.g. say if we convert it to GeoJSON it will fail as it does not support such field). Still I kind of like that you put it inside of that deliveryAreas, makes sense

evereq commented 4 years ago

@valiopld also I like how you did it on Map with max delivery radius, 100% makes sense! One suggestion for the future (not priority) - make it also possible to "drag" such radios in the map (not sure how easy to do it) so user can increase/decrease it directly on the map and it changes value. ;)