Closed Sergemuhundu closed 2 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.
:x: Sergemuhundu
:x: Lenscorpx
You have signed the CLA already but the status is still pending? Let us recheck it.
@Sergemuhundu , please click the button "CLA | not signed yet" (https://github.com/ever-co/ever-demand/pull/1506#issuecomment-1193366581) and follow the requirements of it to sign the CAA document.
@Sergemuhundu, I have some propositions regarding the codes:
When importing dependencies or components, can you follow some classification rules for them?
i.e:
// COMPONENTS
import MyCOmponent from "./components/MyComponent";
// STYLES
import STYLES from "./styles";
It's easier to find your way around and to have a clean code;
❗❗ @Sergemuhundu, I don't think we can merge these codes, you took the codes from another branch intended for the implementation of the Flutter clone
❗❗ @Sergemuhundu, I don't think we can merge these codes, you took the codes from another branch intended for the implementation of the Flutter clone
You have to create a branch from this feature branch
There are too many changes that you didn't implement that end up in this PR;
Try to create another branch from feature/shop-mobile-expoV0.4.3 and name it impl/shop-mobile-expoV0.4.3@orderHistory
.
I close this PR
**Please note: we will close your PR without comment if you do not check the box
How it looks now
es above and provide ALL requested information.**