search

ever-co / ever-demand

Ever® Demand™ - Open Commerce Platform - https://everdemand.co
https://everdemand.co
GNU Affero General Public License v3.0
1.69k stars 456 forks source link

Quick fire-up with docker #1511

Closed sdekna closed 1 year ago

sdekna commented 1 year ago

Hi all,

I spent days trying to work my way through dockerizing the project... and I'm thinking of making a separate docker-compose with enhanced dockerfiles to quickly build and deploy apps apps without the need to have deep technical background to navigate your way through it. Would this be something that you, as project maintainers, be interested in? If yes I can prepare it and send you a pull request.

Thanks.

evereq commented 1 year ago

@sdekna of course feel free to create PR for us to review, thank you!

evereq commented 1 year ago

Just make sure you saw https://github.com/ever-co/ever-demand/tree/develop/.deploy folder with many of existed Dockerfiles etc.

sdekna commented 1 year ago

Excellent! Will get right through it.

sdekna commented 1 year ago

I am nearly done with api and admin, however, I am having trouble with passing environmental variables to angular apps through docker...

I tried with .env, however, the app seems to take all the environmental variables from "/packages/admin-web-angular/scripts/env.ts", and I am not sure how to pass environments variables to it.

Any help would be appreciated.

evereq commented 1 year ago

Sorry, it's hard for me to follow what exactly you are doing because think we have all that already in https://github.com/ever-co/ever-demand/blob/develop/.deploy/admin-web-angular/entrypoint.prod.sh#L6

Did you review how our Dockers are created / used before building your own? What would be the difference between our existed implementation and yours?