ever-co / ever-demand

Ever® Demand™ - Open Commerce Platform - https://everdemand.co
https://everdemand.co
GNU Affero General Public License v3.0
1.69k stars 456 forks source link

changes for implementing French in Admin site. #1569

Closed duncan222 closed 2 months ago

duncan222 commented 2 months ago

I have sent the signed CAA document to the email listed in the contributing guidelines.

These are changes to the admin site to add French to the list of language options. It looked as if French was added as an option on all the other sites, however the French option was missing from the Admin page. I translated the "en-US" JSON file from the admin-web-angular/src/assets/i18n directory to French and placed the contents of this translation into the "fr-FR" JSON file in the same directory.

The last changes made were to the "theme-settings.cpmponent.ts" in the admin-web-angular/src/app/components/theme-settings directory, which were adding French as an option in the drop down list that is presented in the settings side bar.

Please let me know if there is anything else I can do here. Thanks

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Duncan Coll seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

evereq commented 2 months ago

@duncan222 Thank you for sending the doc by email, but just for consistency with other contributors, can you click "CLA | not signed yet" in comment https://github.com/ever-co/ever-demand/pull/1569#issuecomment-2073447925 and follow steps to sign it also online? Thank you so much for your contributions!