ever-co / ever-teams

Ever® Teams™ - Open Work and Project Management Platform - https://ever.team
https://ever.team
GNU Affero General Public License v3.0
282 stars 47 forks source link

[Bug] Issue on adding new package #1631

Closed YehualashetGit closed 1 year ago

YehualashetGit commented 1 year ago

Currently, we are encountering an issue when attempting to add a new package into our apps. This issue results in the following example error message:

here is the command under the corresponding apps directory

yarn add packageName

i.e

  cd app/web
  yarn add @tanstack/react-table

image

evereq commented 1 year ago

@YehualashetGit what command do you run!?

YehualashetGit commented 1 year ago

@YehualashetGit what command do you run!?

I have updated the issue with the command I run

evereq commented 1 year ago

@maceteligolden did you run yarn policies set-version 1.19.0 and result of PR https://github.com/ever-co/ever-teams/pull/1633 is what happens after you run that command?

I found https://github.com/yarnpkg/yarn/issues/8405 and in one of comments they suggest to update nx / lerna packages to latest, did you checked that? https://github.com/yarnpkg/yarn/issues/8405#issuecomment-1341129303

I don't like idea to pin Yarn version that way, however seems others doing it too, e.g. https://github.com/vuetifyjs/vuetify/tree/master/.yarn/releases. Still if we can resolve this without adding yarn binary to our repo that would be preferred approach.

Also, maybe we just need to try yarn v2? :))) No idea if it will work well with all deps we have / with NX and with Lerna etc...

maceteligolden commented 1 year ago

@maceteligolden did you run yarn policies set-version 1.19.0 and result of PR #1633 is what happens after you run that command?

I found yarnpkg/yarn#8405 and in one of comments they suggest to update nx / lerna packages to latest, did you checked that? yarnpkg/yarn#8405 (comment)

I don't like idea to pin Yarn version that way, however seems others doing it too, e.g. https://github.com/vuetifyjs/vuetify/tree/master/.yarn/releases. Still if we can resolve this without adding yarn binary to our repo that would be preferred approach.

Also, maybe we just need to try yarn v2? :))) No idea if it will work well with all deps we have / with NX and with Lerna etc...

yes @evereq i updated the yarn policies. i'll check updating nx and lerna.