search

ever-co / ever-teams

Ever® Teams™ - Open Work and Project Management Platform - https://ever.team
https://ever.team
GNU Affero General Public License v3.0
227 stars 35 forks source link

[Question] Should we remove unused shadcn components? #2300

Closed Anishali2 closed 3 months ago

Anishali2 commented 3 months ago

There are only 10-15 files where shadcn is used and a lot of components are just using space in the project...

evereq commented 3 months ago

Hm, and what we should use instead? I thought to actually use it more and more instead of removing it.... @Anishali2

Anishali2 commented 3 months ago

Sir shad cn require additional configuration for every project I'm studying the project theme design and make components accordingly from chadcn

Anishali2 commented 3 months ago

there are more then 10 shadcn components and libraries that are installed but not used

evereq commented 3 months ago

@Anishali2 please add here the path for those components, i.e. which folder they are located etc. Still, what I think that we probably very soon will end up with usage of all of them in the project anyway. Of course we can remove them and add again when needed too, but that way devs may forget to even check them when needed... I would prefer to just let all devs to know that if they need components, take a look into folder A and build your components on top of shadcn (or others that we may have already added too, like headless UI, etc

Anishali2 commented 3 months ago

Ok Sir I'm not changing any thing but if you agree let me just remove some of these

'@radix-ui/react-hover-card'; this lib is used in components/ui/hover-card.tsx and hover-card component is not used

'@radix-ui/react-dialog' this lib is used in components/ui/command.tsx and command component is not used

'react-day-picker' this lib is used in components/ui/calendar.tsx and calendar component is not used

'@radix-ui/react-avatar' this lib is used in components/ui/avatar.tsx and avatar component is not used.

evereq commented 3 months ago

@Anishali2 let's keep for now all components in the components/ui folder, even those that are not used yet. We will probably move it later into some separate package to be reused across projects etc. I am closing this ticket for now. Thank you!