Closed GloireMutaliko21 closed 4 months ago
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@babel/code-frame@7.22.13, npm/@babel/compat-data@7.22.9, npm/@babel/core@7.22.11, npm/@babel/generator@7.22.10, npm/@babel/helper-compilation-targets@7.22.10, npm/@babel/helper-create-class-features-plugin@7.22.11, npm/@babel/helper-create-regexp-features-plugin@7.22.9, npm/@babel/helper-module-transforms@7.22.9, npm/@babel/helper-remap-async-to-generator@7.22.9, npm/@babel/helper-replace-supers@7.22.9, npm/@babel/helper-validator-identifier@7.22.5, npm/@babel/highlight@7.22.13, npm/@babel/parser@7.22.14, npm/@babel/plugin-syntax-jsx@7.22.5, npm/@babel/plugin-transform-optional-chaining@7.22.12, npm/@babel/plugin-transform-parameters@7.22.5, npm/@babel/plugin-transform-runtime@7.22.10, npm/@babel/preset-env@7.22.14, npm/@babel/preset-react@7.22.5, npm/@babel/runtime@7.22.11, npm/@babel/template@7.22.5, npm/@babel/traverse@7.22.11, npm/@babel/types@7.22.11, npm/@commitlint/cli@17.7.1, npm/@commitlint/config-conventional@17.7.0, npm/@commitlint/config-lerna-scopes@17.7.0, npm/@commitlint/load@17.7.1, npm/@commitlint/travis-cli@17.7.1, npm/@compodoc/compodoc@1.1.21, npm/@cucumber/cucumber-expressions@16.1.2, npm/@cucumber/cucumber@8.11.1, npm/@cucumber/gherkin@25.0.2, npm/@cucumber/messages@21.0.1, npm/@cypress/browserify-preprocessor@3.0.2, npm/@jest/test-result@29.6.4, npm/@jridgewell/trace-mapping@0.3.19, npm/@lerna/legacy-package-management@8.1.2, npm/@lexical/react@0.8.1, npm/@next/eslint-plugin-next@13.4.19, npm/@npmcli/arborist@7.2.2, npm/@npmcli/git@5.0.4, npm/@npmcli/installed-package-contents@2.0.2, npm/@npmcli/map-workspaces@3.0.4, npm/@npmcli/promise-spawn@7.0.1, npm/@npmcli/query@3.1.0, npm/@npmcli/run-script@7.0.2, npm/@nrwl/devkit@16.7.4, npm/@nx/cypress@16.7.4, npm/@nx/detox@16.7.4, npm/@nx/devkit@17.3.2, npm/@nx/eslint-plugin-nx@16.0.0-beta.1, npm/@nx/jest@16.7.4, npm/@nx/linter@16.7.4, npm/@nx/nest@16.7.4, npm/@nx/next@16.7.4, npm/@nx/node@16.7.4, npm/@nx/react@16.7.4, npm/@nx/web@16.7.4, npm/@nx/webpack@16.7.4, npm/@nx/workspace@16.7.4, npm/@semantic-release/changelog@6.0.3, npm/@semantic-release/git@10.0.1, npm/@semantic-release/github@9.2.6, npm/@semantic-release/npm@11.0.3, npm/@types/detox@18.1.0, npm/@types/node@20.12.2, npm/ansi-colors@4.1.3, npm/browserslist@4.21.10, npm/cacache@18.0.2, npm/cli-table3@0.6.3, npm/cloc@2.0.0-cloc, npm/cmd-shim@6.0.1, npm/columnify@1.6.0, npm/commitizen@4.3.0, npm/concurrently@8.2.2, npm/conventional-changelog-cli@2.2.2, npm/conventional-changelog@3.1.25, npm/convert-source-map@1.9.0, npm/cosmiconfig@8.3.3, npm/cross-env@7.0.3, npm/cross-spawn@7.0.3, npm/cspell@8.0.0, npm/cypress-file-upload@5.0.8, npm/cypress@11.2.0, npm/cz-conventional-changelog@3.3.0, npm/detox@20.11.1, npm/dotenv@16.3.1, npm/enquirer@2.3.6, npm/envalid@6.0.2, npm/eslint-config-prettier@8.10.0, npm/eslint-plugin-cypress@2.13.4, npm/eslint-plugin-prettier@4.2.1, npm/eslint-plugin-react@7.33.2, npm/eslint@8.46.0, npm/execa@5.1.1, npm/fast-glob@3.3.1, npm/faye-websocket@0.11.4, npm/figures@3.2.0, npm/fs-extra@11.1.1, npm/get-stream@6.0.0, npm/git-raw-commits@2.0.11, npm/globby@11.1.0, npm/graceful-fs@4.2.11, npm/has-unicode@2.0.1, npm/hosted-git-info@7.0.1, npm/html-entities@2.4.0, npm/husky@9.0.11, npm/i18next@22.5.1, npm/ignore@5.2.4, npm/import-fresh@3.3.0, npm/inherits@2.0.4, npm/ini@1.3.8, npm/inquirer@8.2.4, npm/is-ci@3.0.1, npm/is-installed-globally@0.4.0, npm/istanbul-lib-coverage@3.2.0, npm/jest-resolve@29.6.4, npm/jest-util@29.6.3, npm/js-tokens@4.0.0, npm/json-parse-even-better-errors@3.0.0, npm/json5@2.2.3, npm/lerna-changelog@2.2.0, npm/lerna@8.1.2, npm/lexical@0.8.1, npm/libnpmpublish@7.3.0, npm/lint-staged@10.5.4, npm/load-json-file@6.2.0, npm/lodash.merge@4.6.2, npm/lodash@4.17.21, npm/loglevel@1.8.1, npm/make-dir@4.0.0, npm/make-fetch-happen@13.0.0, npm/minimatch@9.0.3, npm/minimist@1.2.8, npm/minizlib@2.1.2, npm/mz@2.7.0, npm/node-fetch@2.6.7, npm/node-gyp@10.1.0, npm/nopt@7.2.0, npm/npm-install-checks@6.3.0, npm/npm-registry-fetch@14.0.5, npm/npm-run-path@4.0.1, npm/nx-cloud@16.3.0, npm/nx@16.7.4, npm/object-assign@4.1.1, npm/once@1.4.0, npm/onetime@5.1.2, npm/open@8.4.0, npm/pacote@17.0.6, npm/parse-conflict-json@3.0.1, npm/parse-json@5.2.0, npm/path-is-absolute@1.0.1, npm/path-scurry@1.10.1, npm/picomatch@2.3.1, npm/postcss-selector-parser@6.0.13, npm/prettier-eslint-cli@8.0.1, npm/prettier@3.2.5, npm/pretty-quick@4.0.0, npm/progress@2.0.3, npm/promise-call-limit@1.0.2, npm/react-dom@18.3.1, npm/react@18.3.1, npm/read-cmd-shim@4.0.0, npm/read-package-json-fast@3.0.2, npm/read-package-json@6.0.4, npm/resolve-from@5.0.0, npm/resolve-global@1.0.0, npm/rimraf@5.0.5, npm/rxjs@7.8.1, npm/semantic-release@22.0.12, npm/send@0.18.0, npm/signal-exit@3.0.7, npm/slash@3.0.0, npm/source-map@0.7.4, npm/ssri@9.0.1, npm/strong-log-transformer@2.1.0, npm/tar@6.1.11, npm/through2@2.0.5, npm/tmp@0.2.1, npm/traverse@0.6.7, npm/ts-node@10.9.2, npm/tslib@2.6.2, npm/typescript@5.2.2, npm/uuid@9.0.0, npm/validate-npm-package-name@5.0.0, npm/write-file-atomic@5.0.1, npm/write-pkg@4.0.0, npm/yaml@1.10.2, npm/yargs-parser@21.1.1
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎
To accept the risk, merge this PR and you will not be notified again.
Alert | Package | Note | Source |
---|---|---|---|
Telemetry | npm/detox-expo-helpers@0.6.0 |
| |
Telemetry | npm/detox-expo-helpers@0.6.0 |
| |
Telemetry | npm/detox-expo-helpers@0.6.0 |
| |
Install scripts | npm/core-js@2.6.12 |
|
|
Install scripts | npm/@sentry/cli@1.74.4 |
|
This package contains telemetry which tracks how it is used.
Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.
Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.
Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.
If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.
To ignore an alert, reply with a comment starting with @SocketSecurity ignore
followed by a space separated list of ecosystem/package-name@version
specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0
or ignore all packages with @SocketSecurity ignore-all
@SocketSecurity ignore npm/detox-expo-helpers@0.6.0
@SocketSecurity ignore npm/core-js@2.6.12
@SocketSecurity ignore npm/@sentry/cli@1.74.4
@GloireMutaliko21 I don't get logic you describe... You talk about individual task page right? I.e. page that display specific task and that we see "timer" component on that page at site header. If timer is counting time for some other task, we should do nothing, unless user stop that timer and start it again! If stop and start again, we need to switch active task for user to be one that s/he currently see on the page! If timer was stopped before and user starting it, then we need to do the same - select active task for the user to be one displayed on this page! Basically any "start" of timer on some task page, should switch user active task to the one that displayed on the page. Is that clear now?
@GloireMutaliko21 I don't get logic you describe... You talk about individual task page right? I.e. page that display specific task and that we see "timer" component on that page at site header. If timer is counting time for some other task, we should do nothing, unless user stop that timer and start it again! If stop and start again, we need to switch active task for user to be one that s/he currently see on the page! If timer was stopped before and user starting it, then we need to do the same - select active task for the user to be one displayed on this page! Basically any "start" of timer on some task page, should switch user active task to the one that displayed on the page. Is that clear now?
Yes sir @evereq It's clear. This is already done in this PR... The only thing I'm not sure should work as such is that currently, when the page for a specific task loads, I check the timer status. If it's already started, nothing happens. If not, I change the user's active task. So what I'd like to know is whether it should work like this (check when the page loads) or whether I should wait for the timer button to be pressed?
" If it's already started, nothing happens." - you mean timer continues ticking, but you did not change the active task right? " If not, I change the user's active task. " - hm, you should ONLY change active task when the user CLICK START on a timer, not when the user just jumps from one task page to another! How I see it:
Again, honestly, if you think logically about this feature, why we need it!? We want to make sure that user can quickly start tracking time for different tasks right from the tasks pages! I.e. I browsing tasks that exists and see one I like to work on. I click "Start" and timer start for that task and I start working on it. Plus when I moving from one page to another (not only tasks pages, but all app pages), in the header I just want to see my timer status, i.e. if I am running it or not.
That's great sir @evereq, the only concern was "when do we change the user's active task". I'll make sure it's when the user starts the timer on that specific task page, not when it loads... Thanks sir
@GloireMutaliko21 great, let me know when PR is ready to merge :)
Sir @evereq ! The PR is ready to merge :rocket:
We use usePathname Next.js hook to get the current page. If the current page is the "Task" page, when the user clicks on the start button of the timer, we first set the active task to a displayed task