Closed Sergemuhundu closed 2 weeks ago
[!CAUTION]
Review failed
The pull request is closed.
The pull request updates the workflow configurations for building, deploying, and publishing Android and iOS mobile applications. It introduces checks for the EXPO_TOKEN
secret to ensure necessary credentials are provided before proceeding. Additionally, default values for EXPO_PROJECT_PACKAGE_NAME
and EXPO_PROJECT_IOS_BUNDLE_IDENTIFIER
are set to allow workflows to continue even if specific secrets are not defined. Overall, the changes focus on enhancing error handling and maintaining the existing structure of the workflows.
File | Change Summary |
---|---|
.github/workflows/mobile.apps.android.yml | Updated to check for EXPO_TOKEN , added fallback values for app.json , and modified Google credentials masking. |
.github/workflows/mobile.apps.ios.yml | Added EXPO_TOKEN check, fallback values for app.json , and maintained existing steps for App Store credentials. |
.github/workflows/mobile.apps.stage.android.yml | Included EXPO_TOKEN check, updated to use latest Node.js actions, and added fallback values for app.json . |
.github/workflows/mobile.apps.stage.ios.yml | Added EXPO_TOKEN check, fallback values for app.json , and retained existing steps for EAS configuration. |
EXPO_PROJECT_PACKAGE_NAME
and EXPO_PROJECT_IOS_BUNDLE_IDENTIFIER
, which are directly referenced in the main PR's workflow updates for generating app.json
.eas.json
file, which is relevant to the overall configuration and deployment process discussed in the main PR.🐰 In the garden where workflows bloom,
Secrets checked to avoid the gloom.
With defaults set, we hop along,
Building apps, where we belong!
A token here, a bundle there,
Together we’ll deploy with care! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Please include a summary of the changes and the related issue.
Type of Change
Checklist
Previous screenshots
Please add here videos or images of previous status
Current screenshots
Please add here videos or images of previous status
Summary by CodeRabbit
New Features
EXPO_TOKEN
secret in Android and iOS workflows.EXPO_PROJECT_PACKAGE_NAME
andEXPO_PROJECT_IOS_BUNDLE_IDENTIFIER
in case of missing secrets.Bug Fixes
Chores