Closed NdekoCode closed 1 week ago
The changes in the pull request focus on the MainLayout
component within main-layout.tsx
. Key modifications include the addition of two new properties to the component's Props
type, enabling enhanced flexibility for header rendering. The internal logic has been updated to use a reference for the header, allowing for dynamic styling based on its height. The layout structure has also been adjusted to improve responsiveness and manage the main content area’s margin effectively, particularly when a conditional header slot is utilized.
File Path | Change Summary |
---|---|
apps/web/lib/layout/main-layout.tsx | Updated Props type to include mainHeaderSlot and mainHeaderSlotClassName . Modified function signature of MainLayout to incorporate new properties. Added headerRef for dynamic styling based on header height. Adjusted layout structure for responsive design. |
Objective | Addressed | Explanation |
---|---|---|
Ensure only one vertical scrollbar on all pages (#3277) | ❓ | It is unclear if changes directly resolve scrollbar issues. |
Prevent horizontal overflow when the sidebar is extended (#3277) | ❓ | Changes do not explicitly address sidebar overflow concerns. |
🐇 In the layout's dance, a header takes flight,
With slots for a view, oh what a delight!
Margins now shift, as the content does flow,
A single scrollbar, let the smoothness bestow!
Hopping through changes, our layout's refined,
A joyful new world for all users to find! 🌟
[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.
🔧 eslint
> If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.apps/web/lib/layout/main-layout.tsx
Oops! Something went wrong! :( ESLint: 8.46.0 ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct. The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Fix Double Scrollbars and Overflow when extending the Sidebar
Closed #3277
Type of Change
Checklist
Previous screenshots
Please add here videos or images of previous status
https://github.com/user-attachments/assets/6220739f-d390-4278-a172-5e443c426725
Current screenshots
Please add here videos or images of previous status
https://github.com/user-attachments/assets/6c363332-195a-444c-ae68-1e1a9021bad3
Summary by CodeRabbit
New Features
Bug Fixes