Closed CREDO23 closed 1 week ago
The changes in this pull request primarily enhance the AutoCompleteDropdown
component by adding two new properties, setSelectedEmail
and selectedEmail
, to its props. These modifications allow for better management of email selection within the component. The dropdown's visual structure has been simplified by replacing the Card
component with a div
, and the Combobox
input handling has been updated to reflect the current query state more effectively. The InviteEmailDropdown
component has also been updated to integrate these new props, maintaining existing functionality.
File Path | Change Summary |
---|---|
apps/web/lib/components/auto-complete-dropdown.tsx | Added setSelectedEmail and selectedEmail to Props . Updated Combobox handling and dropdown rendering. |
apps/web/lib/features/team/invite/invite-email-dropdown.tsx | Integrated new props into AutoCompleteDropdown . Minor formatting adjustment made. |
Objective | Addressed | Explanation |
---|---|---|
Preserve input of name on Invite Team member (Issue #3111) | ❌ | Changes do not address input preservation issue. |
InviteEmailDropdown
component adds the setSelectedEmail
and selectedEmail
props to the AutoCompleteDropdown
, which directly relates to the changes made in the main PR that also introduces these props to enhance email selection management.feature
In the dropdown where emails play,
A new feature hops in today!
With selected emails now in sight,
Our invites will soar to new height.
So let’s celebrate, with joy and cheer,
For better invites are finally here! 🐇✨
[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.
🔧 eslint
> If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.apps/web/lib/components/auto-complete-dropdown.tsx
Oops! Something went wrong! :( ESLint: 8.46.0 ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct. The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Fix #3111
Type of Change
Checklist
Previous screenshots
Please add here videos or images of previous status
Current screenshots
Loom
Summary by CodeRabbit
New Features
AutoCompleteDropdown
component with new properties for improved email selection management.Bug Fixes
These updates improve the overall user experience when selecting and managing email addresses within the application.