Fix/server web application menu

syns2191 commented 1 week ago

Description

Please include a summary of the changes and the related issue.

Type of Change

[x] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Documentation update

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

Previous screenshots

Please add here videos or images of previous status

Current screenshots

Please add here videos or images of previous status

Summary by CodeRabbit

Release Notes

New Features
- Added a new "MENU_APP" section with Bulgarian and English translations for various application menu items, enhancing localization.
- Introduced a constant IS_DESKTOP_APP to determine if the application is running as a desktop app, affecting authentication logic.
Improvements
- Updated the menu management system for better organization and internationalization.
- Enhanced the styling of the EverTeams logo for improved responsiveness in different themes.
Bug Fixes
- Streamlined error handling and event listeners for improved functionality.

coderabbitai[bot] commented 1 week ago

Walkthrough

The pull request introduces significant changes across multiple files, primarily focusing on enhancing localization through the addition of a new "MENU_APP" section in translation files for both Bulgarian and English. Additionally, modifications to configuration management and menu handling in the Electron application are made, including the introduction of a DEFAULT_CONFIG constant and a revamped MenuBuilder class. The changes also include the removal of an outdated main_.ts file and updates to the authentication logic to incorporate a new constant related to desktop application detection.

Changes

File Path	Change Summary
`apps/server-web/src/locales/i18n/bg/translation.json`	Added "MENU_APP" section with Bulgarian translations for various menu items.
`apps/server-web/src/locales/i18n/en/translation.json`	Added "MENU_APP" section with English translations for various menu items.
`apps/server-web/src/main/helpers/services/libs/desktop-store.ts`	Introduced `DEFAULT_CONFIG` constant for default settings and modified `setDefaultServerConfig` logic.
`apps/server-web/src/main/main.ts`	Updated to import `Menu`, created `appMenu` instance, modified menu initialization, and added new event listeners.
`apps/server-web/src/main/main_.ts`	Removed the file which contained the main process logic for the Electron application.
`apps/server-web/src/main/menu.ts`	Overhauled `MenuBuilder` class, removed and added methods for improved menu management and localization.
`apps/web/app/constants.ts`	Added new constant `IS_DESKTOP_APP` based on an environment variable.
`apps/web/auth.ts`	Imported `IS_DESKTOP_APP` and added `trustHost` property to `NextAuth` configuration.
`apps/renderer/components/svgs/EverTeamsLogo.tsx`	Updated `className` property of `<img>` element for improved styling.

Possibly related PRs

#3160: The addition of environment variables may relate to localization changes, influencing how translations are managed.
#3304: Introduces new server configuration properties, potentially affecting how server settings are presented in different languages.
#3338: Connects to localization updates as it involves user interface elements that could be affected by localization changes.

Suggested labels

WEB, Ever Teams, Bug fix

Suggested reviewers

evereq
Cedric921

Poem

In the land of code where rabbits play,
New menus bloom, brightening the day.
With translations fresh, both near and far,
Our app shines bright, a guiding star.
So hop along, let’s celebrate,
For every change, we elevate! 🐰✨

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint
> If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/server-web/src/main/helpers/services/libs/desktop-store.ts
Oops! Something went wrong! :( ESLint: 8.46.0 ESLint couldn't find the config "erb" to extend from. Please check that the name of the config is correct. The config "erb" was referenced from the config file in "/apps/server-web/.eslintrc.js". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

evereq commented 1 week ago

@syns2191 I am merging this PR now, please create new PR based on develop branch for more fixes

ever-co / ever-teams