ever-co / ever-teams

Ever® Teams™ - Open Work and Project Management Platform - https://ever.team
https://ever.team
GNU Affero General Public License v3.0
282 stars 47 forks source link

Fixes 5 | Team, Task, Settings pages #734

Closed KostyaEver closed 1 year ago

KostyaEver commented 1 year ago
badalkhatri0924 commented 1 year ago

@KostyaEver

Can you check Settings / Personal - change email to another -> should send Code on new email (now does not send) again? I am getting emails (Checked in stage and production both). It is fixed when we did migrations for an email template. If it is working for you now then we can close this.

Duplicate: Settings - change own email to another does not send CODE https://github.com/ever-co/ever-gauzy-teams/issues/587

badalkhatri0924 commented 1 year ago

@KostyaEver @evereq

When the manager deletes only team -> should see the main page without team + button 'Create team'

Should we redirect to the main page?

Currently, when we Manager Dispose the only team we are opening Popup as shown below. And if the manager closes the popup in the Team setting we are already showing Create new Team button.

I think it is not necessary here to redirect to main page as Team setting and Main page UI is almost same for Create new Team button.

image image
badalkhatri0924 commented 1 year ago

@evereq @KostyaEver Settings / Team - Public Team should be selected by default

In my opinion, the team should be Private by default (The current implementation is the same), Not all the users/managers will want the team to be public by default.

Let me know your thoughts on this why we need to make default Public.

KostyaEver commented 1 year ago

@KostyaEver @evereq

When the manager deletes only team -> should see the main page without team + button 'Create team'

Should we redirect to the main page?

Currently, when we Manager Dispose the only team we are opening Popup as shown below. And if the manager closes the popup in the Team setting we are already showing Create new Team button.

I think it is not necessary here to redirect to main page as Team setting and Main page UI is almost same for Create new Team button.

image image

@badalkhatri0924 My bad, so here everything is ok, just the problem that when the user delete team and logout it does not redirect to the main landing page (Login / Create team)

badalkhatri0924 commented 1 year ago

@KostyaEver @evereq When the manager deletes only team -> should see the main page without team + button 'Create team' Should we redirect to the main page? Currently, when we Manager Dispose the only team we are opening Popup as shown below. And if the manager closes the popup in the Team setting we are already showing Create new Team button. I think it is not necessary here to redirect to main page as Team setting and Main page UI is almost same for Create new Team button.

image image

@badalkhatri0924 My bad, so here everything is ok, just the problem that when the user delete team and logout it does not redirect to the main landing page (Login / Create team)

I've fixed this today @KostyaEver.

paradoxe35 commented 1 year ago

Team Settings - when a user creates a custom Status, Priority, Size should select a custom icon if not selected in the purpose

@badalkhatri0924 we need an API to upload a custom task status icon

badalkhatri0924 commented 1 year ago

Team Settings - when a user creates a custom Status, Priority, Size should select a custom icon if not selected in the purpose

@badalkhatri0924 we need an API to upload a custom task status icon

@paradoxe35 @KostyaEver I think custom icon upload we aren't doing in v1. @KostyaEver As I remember we decided that we might be using some libraries to show available icons.

KostyaEver commented 1 year ago

Team Settings - when a user creates a custom Status, Priority, Size should select a custom icon if not selected in the purpose

@badalkhatri0924 we need an API to upload a custom task status icon

@paradoxe35 @KostyaEver I think custom icon upload we aren't doing in v1. @KostyaEver As I remember we decided that we might be using some libraries to show available icons.

Thoughts about 'Custom icon' Here I meant that it is any icon within the available list of icons and color (random selection). So once the user creates new Status or Priority or Size - the system should select any of the available icons and colors (for sure user can select any). Example: the user is about to create new Size and call it 'Dog' so the system should select any icon.

Yes @badalkhatri0924 is right we are going to use an existing library (seems like we already use it)

@paradoxe35 @badalkhatri0924

Please, correct me @evereq if I am wrong

badalkhatri0924 commented 1 year ago

Team Settings - when a user creates a custom Status, Priority, Size should select a custom icon if not selected in the purpose

@badalkhatri0924 we need an API to upload a custom task status icon

@paradoxe35 @KostyaEver I think custom icon upload we aren't doing in v1. @KostyaEver As I remember we decided that we might be using some libraries to show available icons.

Thoughts about 'Custom icon' Here I meant that it is any icon within the available list of icons and color (random selection). So once the user creates new Status or Priority or Size - the system should select any of the available icons and colors (for sure user can select any). Example: the user is about to create new Size and call it 'Dog' so the system should select any icon.

Yes @badalkhatri0924 is right we are going to use an existing library (seems like we already use it)

@paradoxe35 @badalkhatri0924

Please, correct me @evereq if I am wrong

@KostyaEver We are not using any library as of now. We are showing static list which is already uploaded to backend.

May be for this We can select 1st icon by default while creating new status/label etc...

KostyaEver commented 1 year ago

Team Settings - when a user creates a custom Status, Priority, Size should select a custom icon if not selected in the purpose

@badalkhatri0924 we need an API to upload a custom task status icon

@paradoxe35 @KostyaEver I think custom icon upload we aren't doing in v1. @KostyaEver As I remember we decided that we might be using some libraries to show available icons.

Thoughts about 'Custom icon' Here I meant that it is any icon within the available list of icons and color (random selection). So once the user creates new Status or Priority or Size - the system should select any of the available icons and colors (for sure user can select any). Example: the user is about to create new Size and call it 'Dog' so the system should select any icon. Yes @badalkhatri0924 is right we are going to use an existing library (seems like we already use it) @paradoxe35 @badalkhatri0924 Please, correct me @evereq if I am wrong

@KostyaEver We are not using any library as of now. We are showing static list which is already uploaded to backend.

May be for this We can select 1st icon by default while creating new status/label etc...

ok, I see. we can use 1st as you said OR is it difficult to add a method where the system randomly selects any available icon and color?

badalkhatri0924 commented 1 year ago

Team Settings - when a user creates a custom Status, Priority, Size should select a custom icon if not selected in the purpose

@badalkhatri0924 we need an API to upload a custom task status icon

@paradoxe35 @KostyaEver I think custom icon upload we aren't doing in v1. @KostyaEver As I remember we decided that we might be using some libraries to show available icons.

Thoughts about 'Custom icon' Here I meant that it is any icon within the available list of icons and color (random selection). So once the user creates new Status or Priority or Size - the system should select any of the available icons and colors (for sure user can select any). Example: the user is about to create new Size and call it 'Dog' so the system should select any icon. Yes @badalkhatri0924 is right we are going to use an existing library (seems like we already use it) @paradoxe35 @badalkhatri0924 Please, correct me @evereq if I am wrong

@KostyaEver We are not using any library as of now. We are showing static list which is already uploaded to backend. May be for this We can select 1st icon by default while creating new status/label etc...

ok, I see. we can use 1st as you said OR is it difficult to add a method where the system randomly selects any available icon and color?

@KostyaEver we can do random too. will take almost same time.

paradoxe35 commented 1 year ago

The random color features has been implemented already @KostyaEver

badalkhatri0924 commented 1 year ago

The random color features has been implemented already @KostyaEver

Yup, random color is done but icon is pending.

@paradoxe35 @KostyaEver I'll do it.

evereq commented 1 year ago

Team Settings - when a user creates a custom Status, Priority, Size should select a custom icon if not selected in the purpose

@badalkhatri0924 we need an API to upload a custom task status icon

@paradoxe35 @KostyaEver I think custom icon upload we aren't doing in v1. @KostyaEver As I remember we decided that we might be using some libraries to show available icons.

Thoughts about 'Custom icon' Here I meant that it is any icon within the available list of icons and color (random selection). So once the user creates new Status or Priority or Size - the system should select any of the available icons and colors (for sure user can select any). Example: the user is about to create new Size and call it 'Dog' so the system should select any icon. Yes @badalkhatri0924 is right we are going to use an existing library (seems like we already use it) @paradoxe35 @badalkhatri0924 Please, correct me @evereq if I am wrong

@KostyaEver We are not using any library as of now. We are showing static list which is already uploaded to backend. May be for this We can select 1st icon by default while creating new status/label etc...

ok, I see. we can use 1st as you said OR is it difficult to add a method where the system randomly selects any available icon and color?

Just select one icon, not random please. Make sure that icon mean something more or less universal

evereq commented 1 year ago

Please do not select random icon, it's for sure bad idea. Select one icon by default that looks generic, e.g. some empty circle or dot etc. Color random is good, but icon is bad

badalkhatri0924 commented 1 year ago

@KostyaEver @evereq May be by default we can select 1st one?

image