ever-co / ever-traduora

Ever® Traduora™ - Open Translation Management Platform - https://traduora.co
https://traduora.co
GNU Affero General Public License v3.0
1.97k stars 197 forks source link

Feat: add export with untranslated keys #389

Closed vvadymk closed 1 year ago

vvadymk commented 1 year ago

This change resolves #388 by adding ability to export untranslated keys

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
traduora-docs-co ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 6:02pm
evereq commented 1 year ago

Hey @vvadymk , can you fix tiny Lint issue: https://app.circleci.com/pipelines/github/ever-co/ever-traduora/818/workflows/24dd93e5-092a-4a35-ad01-eba0ce10186a/jobs/1161?invite=true#step-109-89. Thanks in advance!

evereq commented 1 year ago

@vvadymk seems now some tests are failing and it's related to column names changes? Can you check please https://app.circleci.com/pipelines/github/ever-co/ever-traduora/820/workflows/a4bc7635-91ab-487f-be6a-667373a0d79d/jobs/1166/parallel-runs/0/steps/0-110

vvadymk commented 1 year ago

Hi @evereq! I have already fixed lint issue. Now I am fixing tests

evereq commented 1 year ago

@vvadymk hm, does not look like tests are fixed... still complains about incorrect names of columns with that "_" etc.

vvadymk commented 1 year ago

@evereq I am still in work. I haven' t changed the db columns

vvadymk commented 1 year ago

where do you see that the problem is in db columns?

evereq commented 1 year ago

In https://app.circleci.com/pipelines/github/ever-co/ever-traduora/820/workflows/a4bc7635-91ab-487f-be6a-667373a0d79d/jobs/1166/parallel-runs/0/steps/0-110, search for "ER_BAD_FIELD_ERROR: Unknown column 'term.project_id' in 'where clause'"

vvadymk commented 1 year ago

@evereq I got it. I also have made a migration to pgsql and rename columns a bit from MySQL version. I will fix it now

vvadymk commented 1 year ago

@evereq If I have a working psql version, how could I suggest my variant?

evereq commented 1 year ago

I think we just need to support both MySQL and PostgreSQL with TypeORM, i.e. should be switch based on "type" of the DB, but I wonder, what are differences you notice? I.e. why do we need to change column names, it did not work with those we already have? We are very interested to make sure Traduora works well with PostgreSQL same as our other products, will be great if you can help with that. Maybe you can create a separate GitHub issue about PostgreSQL support and let's discuss it there if you are interested? @vvadymk

vvadymk commented 1 year ago

There was a lot of problems during migration to pgsql. But finally, I have migrated it and it works good. I renamed it because there was conflicts between table and column naming un pgsql

vvadymk commented 1 year ago

I have fixed problem with this branch and pushed right now

vvadymk commented 1 year ago

I could create an issue and branch with my pgsql version

vvadymk commented 1 year ago

@evereq it could be merged. I have fixed all issues.