search

ever-co / ever-traduora

Ever® Traduora™ - Open Translation Management Platform - https://traduora.co
https://traduora.co
GNU Affero General Public License v3.0
1.97k stars 197 forks source link

Feat: add postgresql as db #391

Closed vvadymk closed 10 months ago

vvadymk commented 11 months ago

This PR resolves #390 by using a postgreSQL as a db.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
traduora-docs-co ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 4:08pm
vvadymk commented 11 months ago

Hi @evereq! As we have discussed about postgresql in the previous pr I created a pr with my changes to support this db.

evereq commented 11 months ago

Hey @vvadymk that's amazing, thank you so much! I think we will have to do a bit more work actually to make sure that BOTH MySQL and PostgreSQL are supported (and also SQLite). So we can have a "switch" of DB type and it should be possible to set it to switch between DBs. Is it something you think you can do or it's better if we assign our engineer to this and reuse code from that PR to make it somehow work alongside existed code? (e.g. migrations should have "CASE" switch that run specific migrations depending on selected DB type and other similar improvements, etc)

vvadymk commented 11 months ago

@evereq thank you for the review. I could do it by myself and push into this pr. I also will fix failed tests.

vvadymk commented 11 months ago

Hi @evereq! this task is in progress and it isn't forgotten. I will try to finish it on weekends

vvadymk commented 10 months ago

Hi! @evereq! I have pushed feature that the Traduora could work either with PostgreSQL or with MySQL.

evereq commented 10 months ago

Thank you so much @vvadymk, I will review it over the next few days and get back! (got a bit sick, and needs to recover)

vvadymk commented 10 months ago

@evereq I wish you the fastest get well!