search

everestpipkin / image-scrubber

A friendly browser-based tool for anonymizing photographs taken at protests
https://everestpipkin.github.io/image-scrubber
MIT License
932 stars 82 forks source link

Brush size cursor not visible halfway thru slider #16

Open jldohmann opened 4 years ago

jldohmann commented 4 years ago

First off, thank you so much for making this tool! I'm interested in helping out however I can, and am currently using the application to figure out how it works.

The brush size slider cursor seems to disappear after halfway thru the slider. This doesn't affect functionality, but visually I was thrown off when the circular cursor didn't appear because it appears for smaller brush sizes.

I wasn't able to take a screenshot with the cursor visible, but here's about where I last see the cursor before it disappears: Screen Shot 2020-06-01 at 2 24 46 PM

And when it's here (or further right) the cursor no longer appears: Screen Shot 2020-06-01 at 2 24 57 PM

This affects Firefox and Chrome browsers (Safari is unaffected by this, though it does have seemingly smaller brush sizes compared to the other browsers).

everestpipkin commented 4 years ago

Thank you for this! I was unable to get the same behavior on my end, but it isn't shocking- the custom cursor generation is a little bit of a hack. Can I ask what OS you're running? And if anyone else is able to reproduce this bug please let me know.

jldohmann commented 4 years ago

No problem! I'm happy to take a look at it myself: which file(s) contains the generation code?

I'm using Mac, version 10.14.6 (Mojave). I have a windows machine too, I'll check it out there as well and add on what I find 😃

aninuth commented 4 years ago

I'm using Chrome, running on Ubuntu 18.04. I'm not having the same issue?

On Chrome on Android, I'm seeing the three grey bars inside the slider's cursor disappearing at certain points, but the rectangle itself is still visible.

Playing around with dev tools on my laptop (Chrome on Ubuntu), simulating different devices' screen sizes/resolutions doesn't change anything, the issue doesn't show up.

everestpipkin commented 4 years ago

Found this error - Gecko browsers do not display cursors larger than 128 x 128 pixels. I'm seeing if I can force a css zoom on the cursor only.

everestpipkin commented 4 years ago

I can't but I think I can set the cursor to none and then have an image follow instead :)