search

everestpipkin / image-scrubber

A friendly browser-based tool for anonymizing photographs taken at protests
https://everestpipkin.github.io/image-scrubber
MIT License
928 stars 82 forks source link

Add zoom slider #21

Closed bMacSwigg closed 4 years ago

bMacSwigg commented 4 years ago

Addresses my suggestion in #17 (Open for feedback on the FR/other solutions, but it was pretty quick to code up so I decided to go ahead and write it.)

Comparison images:

Note that on mobile, this changes the image's vertical position from centered to just below the top bar. I could prevent this with margins, but then it caused the slider to zoom the margins as well. I'm happy to look into other workarounds if the UI change is undesirable.

everestpipkin commented 4 years ago

Would love to see this integrated but it breaks centering for me - will look into it and see if I can get it working.

bMacSwigg commented 4 years ago

Would love to see this integrated but it breaks centering for me - will look into it and see if I can get it working.

I noticed that it changed the vertical centering on mobile :( Come to think of it, it wouldn't terribly surprise me if it broken other centering as well for similar reasons. For at least that vertical centering, I could correct it by adding margins, but then when zooming in the margins stay and it becomes a bit weird because you can scroll up/down into unnecessary white space. Would love to find a solution that's more dynamic.