everestpipkin / image-scrubber

A friendly browser-based tool for anonymizing photographs taken at protests
https://everestpipkin.github.io/image-scrubber
MIT License
928 stars 82 forks source link

Absolutely critical mobile issue re: security layer #34

Closed everestpipkin closed 4 years ago

everestpipkin commented 4 years ago

Just found that the pixelization and shuffling layer is not running on my phone, but runs perfectly in browser or emulated mobile environment. Currently my phone (iphone 6) is only blurring, which while not a simple blur is not enough to guarantee anyone's safety. I'm going to try to backtrack in the code to see when this broke, so may see a series of quick commits - no need to merge into your branches. If anyone has any ideas or can test on their own devices please let me know.

everestpipkin commented 4 years ago

I've found the bug - something I think specific to my slightly older iOS, blessedly - where the canvas needed to be manually scaled as the drawimage function was not upscaling the pixelized canvas. My guess is that this has not affected most users as my software is not up to date and this is standardized now, but I'm still going to fix it across the board by adding a scale outside of that function.

everestpipkin commented 4 years ago

Fixed and merged in w master.