search

everestpipkin / image-scrubber

A friendly browser-based tool for anonymizing photographs taken at protests
https://everestpipkin.github.io/image-scrubber
MIT License
939 stars 82 forks source link

Black brush hard to see on dark/black background #36

Closed arp242 closed 4 years ago

arp242 commented 4 years ago

Cool little tool :-)

I just noticed that the black brush is rather hard (or even impossible!) to see on a black background. Perhaps using something like a white outline or changing colours depending on the background colour might be better?

Here's the image I used for testing (just something I happened to have in my ~/, heh): https://user-images.githubusercontent.com/1032692/83760969-40cb4000-a6a8-11ea-9037-485eb218fe48.jpg

(perhaps not entirely the intended use case for this, but I thought it would be worth making a quick report about it nonetheless).

everestpipkin commented 4 years ago

PR #43 solves this!

bMacSwigg commented 4 years ago

I'm not sure if #43 completely addresses this -- I think there's an additional issue that the paint stroke itself, rather than just the cursor, can be hard to see against a black background.

This is probably low priority, since if the background is black enough that you can't see where you've blurred/painted, then it probably doesn't have sensitive info that needs to be painted or blurred. But it might be worth keeping this issue open to track improving the contrast of the brush's path/stroke itself.