search

everestpipkin / image-scrubber

A friendly browser-based tool for anonymizing photographs taken at protests
https://everestpipkin.github.io/image-scrubber
MIT License
928 stars 82 forks source link

interpolatePath check #38

Closed SaFrMo closed 4 years ago

SaFrMo commented 4 years ago

Working on documentation for the project, I'm not sure what these lines are for - it looks like the rectangles they're drawing are covered up by the circle drawn in these lines. Is that first block of code needed for anything or can it be removed? Thanks!

everestpipkin commented 4 years ago

I didn’t write it so I could be wrong, but I believe they are both needed for smooth line interpolation at higher mouse speeds.

On Fri, Jun 5, 2020 at 7:44 AM Sander Moolin notifications@github.com wrote:

Working on documentation for the project, I'm not sure what these lines https://github.com/everestpipkin/image-scrubber/blob/master/scripts/js.js#L229-L235 are for - it looks like the rectangles they're drawing are covered up by the circle drawn in these lines https://github.com/everestpipkin/image-scrubber/blob/master/scripts/js.js#L237-L241. Is that first block of code needed for anything or can it be removed? Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/everestpipkin/image-scrubber/issues/38, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYH7MMZNVGETB7RREX6PADRVDSDZANCNFSM4NTQVISQ .

SaFrMo commented 4 years ago

Great, thanks!