evereux / pycatia

python module for CATIA V5 automation
MIT License
196 stars 53 forks source link

[FEATURE REQUEST] : Add CATAnalysis type in allowed_document_types #210

Closed RoshanArute closed 5 months ago

RoshanArute commented 5 months ago

Hi,

I would like to use python to create CATAnalysis document pycatia. Currently, CATAnalysis are not even in the document type that are recognized. Hence we can not create a add the document. But we already have all the required interfaces to handle analysis document scenario except its creation.

At my side I had added CATAnalysis type in allowed_document_types of pycatia/scripts/document_types.py. It successfuly creates the Analysis document and all other interfaces works as expected for same document.

So could you please add "CATAnalysis" type in allowed list of types ?

Thank you for your time and expertise.

Minor bug - Typo error -additional "_" at end of import in pycatia/analysis_interfaces/analysis_manager.py

def import_(self, i_document_to_import: Document) -> None:

evereux commented 5 months ago

I was planning on adding all the doc types I can figure out this weekend.

I'll take a look at that bug report too.

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


From: RoshanArute @.> Sent: Saturday, May 18, 2024 9:26:08 AM To: evereux/pycatia @.> Cc: evereux @.>; Assign @.> Subject: [evereux/pycatia] [FEATURE REQUEST] : (Issue #210)

Hi,

I would like to use python to create CATAnalysis document pycatia. Currently, CATAnalysis are not even in the document type that are recognized. Hence we can not create a add the document. But we already have all the required interfaces to handle analysis document scenario except its creation.

At my side I had added CATAnalysis type in allowed_document_types of pycatia/scripts/document_types.py. It successfuly creates the Analysis document and all other interfaces works as expected for same document.

So could you please add "CATAnalysis" type in allowed list of types ?

Thank you for your time and expertise.

Minor bug - Typo error -additional "_" at end of import in pycatia/analysis_interfaces/analysis_manager.py

def import_(self, i_document_to_import: Document) -> None:

— Reply to this email directly, view it on GitHubhttps://github.com/evereux/pycatia/issues/210, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEXQWRELEJGQONVHAKSNOOTZC4GCBAVCNFSM6AAAAABH5IYIRWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYDGOJSGUZDMOI. You are receiving this because you were assigned.Message ID: @.***>

evereux commented 5 months ago

def import_(self, i_document_to_import: Document) -> None:

This wasn't a typo. Whilst I think you can use import as a class method name it's generally a bad idea. My IDEs really complain if I try.

evereux commented 5 months ago

You can now add this document type in 0.6.9.