search

evermeer / EVCloudKitDao

Simplified access to Apple's CloudKit
Other
645 stars 65 forks source link

changed convertionOptions to conversionOptions #64

Closed n-studio closed 8 years ago

n-studio commented 8 years ago

API change introduced in: https://github.com/evermeer/EVReflection/commit/11d2a31c78693216a5ac154fb6bcde7e57e833a4 https://github.com/evermeer/EVReflection/commit/cdc3df8305eefd26c55afa7cb57252ec2ca79c5c

evermeer commented 8 years ago

Thanks,

I see that you have also changed the conversionOptions from .None to .DefaultComparing? Maybe it should indeed be possible to add the conversion functions. I doubt if it will be used much. But then, maybe it should be .DefaultSerialize. They will do the same at this moment, but it will describe better what it does. What do you think?

n-studio commented 8 years ago

Oh, my bad. I shouldn't have changed None to DefaultComparing. Maybe it's even better to remove the argument and let the default value?

EVReflection.fromDictionary(CKRecordToDictionary(record), anyobjectTypeString: record.recordType)
evermeer commented 8 years ago

Yes, you are right. I just changed this and pushed it to GitHub and CocoaPods as version 2.20.1

Thanks again for reporting this!