search

everoute / ipam

everoute ipam for everoute cni and ecp cni
1 stars 1 forks source link

feat: ippool add attribute of private #30

Closed qingwusunny closed 9 months ago

qingwusunny commented 9 months ago

add field ippool.Spec.Private when ippool.Spec.Private=true, if pod doesn't specify pool, it can't allocate ip from this pool

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4898036) 69.97% compared to head (4d80fd6) 70.05%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/everoute/ipam/pull/30/graphs/tree.svg?width=650&height=150&src=pr&token=ol7PVNGwvq&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=everoute)](https://app.codecov.io/gh/everoute/ipam/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=everoute) ```diff @@ Coverage Diff @@ ## main #30 +/- ## ========================================== + Coverage 69.97% 70.05% +0.08% ========================================== Files 9 9 Lines 716 718 +2 ========================================== + Hits 501 503 +2 Misses 176 176 Partials 39 39 ``` | [Files](https://app.codecov.io/gh/everoute/ipam/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=everoute) | Coverage Δ | | |---|---|---| | [pkg/ipam/ipam.go](https://app.codecov.io/gh/everoute/ipam/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=everoute#diff-cGtnL2lwYW0vaXBhbS5nbw==) | `74.74% <100.00%> (+0.17%)` | :arrow_up: |
qingwusunny commented 9 months ago

private pool 还有其他可能的应用场景吗，是否要考虑通用性问题

其实有其他的几个想法：