everoute / ipam

everoute ipam for everoute cni and ecp cni
1 stars 1 forks source link

fix: ipam only list ippool with specified namespace #31

Closed qingwusunny closed 8 months ago

qingwusunny commented 9 months ago

ipam 对象会指定ippool namespace(ipam.namespace),get ippool资源时会自动使用这个字段填充ippool的namespace字段,所以list ippool时也约束在这个namespace下,以免get 不在这个namespace下的ippool报错

codecov[bot] commented 9 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1cef479) 70.05% compared to head (0c6d8bb) 69.66%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/everoute/ipam/pull/31/graphs/tree.svg?width=650&height=150&src=pr&token=ol7PVNGwvq&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=everoute)](https://app.codecov.io/gh/everoute/ipam/pull/31?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=everoute) ```diff @@ Coverage Diff @@ ## main #31 +/- ## ========================================== - Coverage 70.05% 69.66% -0.39% ========================================== Files 9 9 Lines 718 722 +4 ========================================== Hits 503 503 - Misses 176 179 +3 - Partials 39 40 +1 ``` | [Files](https://app.codecov.io/gh/everoute/ipam/pull/31?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=everoute) | Coverage Δ | | |---|---|---| | [pkg/ipam/ipam.go](https://app.codecov.io/gh/everoute/ipam/pull/31?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=everoute#diff-cGtnL2lwYW0vaXBhbS5nbw==) | `73.73% <0.00%> (-1.01%)` | :arrow_down: |