evershopcommerce / evershop

🛍️ NodeJS E-commerce Platform
https://evershop.io/
GNU General Public License v3.0
4.09k stars 1.13k forks source link

[BUG] Stripe API change could cause evershop payments to fail starting October 30 #363

Open kaysond opened 10 months ago

kaysond commented 10 months ago

Just got the following email from Stripe. Is evershop affected?


Hi,

We’re writing to let you know about an upcoming change that we’re making to the PaymentIntents and SetupIntents APIs relating to the return_url parameter.

We’re letting you know because we can see that you’ve made PaymentIntent/SetupIntent confirmation requests without the return_url parameter within the past 3 months, and we want to make sure you have enough time to implement a solution.

What’s changing and what you need to do

From October 30, 2023, all PaymentIntent/SetupIntent confirmation requests will be required to supply a return_url parameter. Requests that do not specify a return_url will return an error. To avoid these errors, you will need to update your integration to supply a return_url before October 30, 2023. You can learn more about how to supply a return_url based on your integration type in our docs.

If you do not wish to handle redirect based payment methods in your Stripe integration, set the automatic_payment_methods.allow_redirects parameter to never when creating your PaymentIntent/SetupIntent.

If you are using a third-party plugin and are unable to update your integration by yourself, please reach out to your plugin provider to make this change to avoid disruption of your payments service.

Why we’re making this change

A return_url is required to successfully complete payments that require redirection. It represents the URL that your customer is redirected back to after they authenticate or cancel their payment on the payment method’s app or site. See our docs for guidance on which payment methods require redirection.

Currently, when redirect based payment methods are enabled on the Stripe Dashboard without supplying a return_url through code, any confirmation attempt using that redirect based payment method will fail. With this change, your integration is made future-proof: by making sure that return_url is supplied for all PaymentIntent/SetupIntent confirmation requests, your Stripe integration will work seamlessly with redirect payment methods should you choose to enable them.

If you need more time to prepare for this change, please let us know at payment-methods-redirects@stripe.com and we may be able to extend a grace period. For general questions or concerns, you can contact us from our support site at any time.

— The Stripe team

ultimate-tester commented 10 months ago

Just to provide my view on this, this will be mitigated by implementing #345 because the return_url is provided with that PR.

kaysond commented 10 months ago

Just to provide my view on this, this will be mitigated by implementing #345 because the return_url is provided with that PR.

Is evershop currently using a redirect based payment method? It seems to me that it's just loading an iframe or something? Since you never change pages

treoden commented 10 months ago

Hi @kaysond ,

Thanks for this ticket. Let's me check it again and get back soon Thanks