evershopcommerce / evershop

🛍️ NodeJS E-commerce Platform
https://evershop.io/
GNU General Public License v3.0
4.5k stars 1.24k forks source link

Handle limits if it is not a category in a subpage #655

Open risjai opened 3 weeks ago

risjai commented 3 weeks ago

Remove any default limits for categories if its displayed on any other page where parent is present. Bug : https://github.com/evershopcommerce/evershop/issues/630

https://github.com/user-attachments/assets/4ad4f2c0-d9a5-480e-83cd-79c35c1460e5

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Other information

treoden commented 3 weeks ago

Hi @risjai ,

It is not about root category listing, if you click on each category we need to make sure the sub categories are rendered full and correct

risjai commented 3 weeks ago

Hi @risjai ,

It is not about root category listing, if you click on each category we need to make sure the sub categories are rendered full and correct

@treoden Yup! I have tested that as well. That also works. You can try applying the patch.

risjai commented 3 weeks ago

Hi @risjai , It is not about root category listing, if you click on each category we need to make sure the sub categories are rendered full and correct

@treoden Yup! I have tested that as well. That also works. You can try applying the patch.

@treoden do you see any problems here?