search

eversign / eversign-php-sdk

The official eversign PHP SDK
https://eversign.com
MIT License
17 stars 24 forks source link

change uppercase Only to lowercase for eversign api to handle properly #39

Closed justinmwood closed 3 years ago

justinmwood commented 3 years ago

read only fields were still editable

Readable.php Line 42 private $readOnly; private $readonly; Line 45 $this->readOnly = !!$readOnly; $this->readonly = !!$readOnly; Line 49 return !!$this->readOnly; return !!$this->readonly;

I tested with the above changes and it started working correctly for me.

archivelm commented 3 years ago

Hi @justinmwood

Firstly, thanks for reporting this, much appreciated. I made a fix and made a new release here https://github.com/eversign/eversign-php-sdk/releases/tag/1.19.1

All best and stay safe! :) Milan