search

evert0n / koa-cors

CORS middleware for Koa
MIT License
243 stars 48 forks source link

Access-Control-Allow-Headers determined by first request (and clean up) #25

Closed jclem closed 9 years ago

jclem commented 9 years ago

If options.headers is not set, it is permanently set to the value of this.header['access-control-request-headers'] of the first request processed by this middleware. I can't see why this is the desired behavior in any case.

TheThing commented 9 years ago

:+1:

This was causing major ghost bugs on my production environment.

emgeee commented 9 years ago

:+1:

jclem commented 9 years ago

Just got bit by this again, because I forgot to use my fork. This really needs to be merged.

TheThing commented 9 years ago

Yeah, I really wish the author would merge this :<

Let's make our own library with less bugs and blackjack! And allow pull requests!

BDiehr commented 9 years ago

:+1:

evert0n commented 9 years ago

Sorry guys so long, I'm taking a look.

evert0n commented 9 years ago

It's now merged, Thanks for the good work.