search

evertrue / exhibitor-cookbook

Cookbook for Netflix Exhibitor
Other
16 stars 27 forks source link

Refactor to correctly offer install methods #38

Closed jeffbyrnes closed 8 years ago

jeffbyrnes commented 8 years ago

Fixes #37, relates to #34.

This introduces some breaking changes to the cookbook, primarily around the install_method attributes.

Consider it a precursor to the breaking changes eventually coming with #36.

@tylermarshall, would love your 👀 on this.

jeffbyrnes commented 8 years ago

Green build wooooo!

tylermarshall commented 8 years ago

@jeffbyrnes , sorry for the delay. It's been a crazy week. I'll still take a look at these changes before the week's over.

tylermarshall commented 8 years ago

@jeffbyrnes I finally had the time to review these changes and they all check out. I appreciate the work on this and it resolves all my issues. If anything comes up I'll be sure to put in another PR to resolve my issues.

jeffbyrnes commented 8 years ago

@tylermarshall glad to hear it! Enjoy v2.0.0 of the cookbook, with all of these changes baked in.