Slight refactor to use zookeeper ~> 8.0

evertrue / exhibitor-cookbook

Cookbook for Netflix Exhibitor

Other

16 stars 27 forks source link

Slight refactor to use zookeeper ~> 8.0 #42

Closed jeffbyrnes closed 7 years ago

jeffbyrnes commented 7 years ago

Closes #36

Doesn’t change anything else about this cookbook, but should get things updated enough to work with zookeeper cookbook 8.x.

jeffbyrnes commented 7 years ago

@vanwho, @williamsjj, @BDeus, @davidsayers, I’d love your 👀 on this as well, since you were all good at reminding me this needed doing.

davidsayers commented 7 years ago

A couple of minor things but LGTM

jeffbyrnes commented 7 years ago

It seems that the maven-based installation doesn’t work, apparently b/c node['java']['java_home'] is unset somehow before it’s used in exhibitor::service. No idea how or why. I’ve attempted to hard-code the path as a fallback if the value is nil.

jeffbyrnes commented 7 years ago

Well, this still fixes the other issue, and I’m not sure anyone’s even using the maven-based install. I’ll cut a breaking release and get this shipped.