search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 119 forks source link

First pass at making using the java cookbook optional. #100

Closed solarce closed 10 years ago

solarce commented 10 years ago

First pass at making using the java cookbook optional.

For #84.

solarce commented 10 years ago

I am not sure if this is the best way to do this, but it seems to work when testing with my wrapper cookbook, so feedback will be very much appreciated

jakedavis commented 10 years ago

This looks legit. I really want to avoid adding recipes and attributes here when possible, but we've already leaned in a bit. I also think the use-case here makes sense. Will merge tonight.

jeffbyrnes commented 10 years ago

Interesting idea. Appreciate that it defaults to true.

jakedavis commented 10 years ago

By "will merge tonight" I obviously meant this morning duh. Doing it.