evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 119 forks source link

Add system flag to zookeeper user #117

Closed timspencer closed 9 years ago

timspencer commented 9 years ago

In my world, we nuke all non-system accounts that weren't added by our centralized management tools, so I put this change in and thought I'd submit it to see if you thought it was a good idea too.

Thanks, and have fun!

jeffbyrnes commented 9 years ago

:+1: on the zookeeper user being considered a system user, though I know with Exhibitor v1.5.2 and Zookeeper 3.4.5, it's had some difficulties if there isn't a home folder to write some Java settings to. That might be a misconfiguration on my part, of course.

jeffbyrnes commented 9 years ago

I'm still :+1: on this, though line 89 should just be:

u

No need for the return. Also, this appears to need a rebase to be merge-able again.

jeffbyrnes commented 9 years ago

Closing in favor of #142